Skip to content

feat(helm): let release-chart consume validated artifacts - #988

Merged
neilime merged 2 commits into
mainfrom
feat/helm-release-artifact-input
Nov 17, 2026
Merged

neilime merged 2 commits into
mainfrom
feat/helm-release-artifact-input

Conversation

@neilime

@neilime neilime commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

helm/release-chart now accepts an immutable artifact ID and archive basename from the current workflow run, alongside the original archive checksum. It owns input validation, exact download, artifact digest enforcement and cleanup, so callers no longer duplicate these steps. Local archive input remains supported and caller-owned files are retained.

The composed release workflow now passes validation outputs directly to the action. Validation and publication remain separate; checksum verification before registry access, immutable push snapshots, retry behavior, signing and publication permissions are preserved. Expired or deleted artifacts fail; a publication-only retry uses the successful validation's original ID. No new runtime dependency or installation step is introduced.

Validation: all 32 Node 24 tests pass (174 ms), including 12 focused cases for source selection, malformed input, isolated download storage and cleanup ownership. Actionlint, offline zizmor, Biome, YAML formatting, Markdown/text lint and diff checks pass. Action and workflow docs were regenerated with CI Dokumentor. The existing composed-workflow integration exercises artifact publication; the existing unsigned checksum-rejection fixture now downloads an artifact and checks failure cleanup. No extra cluster or application image fixture is added. Native CI for 9fd7b32 passed all 232 executed jobs with 77 expected nested skips. All PR checks pass or have expected skips; none are failing or pending. The action integration jobs took 39s and 44s; composed chart validation, publication and identity assertions took 74s, 26s and 9s. These measurements describe the existing integration jobs; no workflow speedup is claimed. The published fixture archive checksum and signature match the validated artifact.

Addresses the artifact download/cleanup feedback in cloud-native-aixmarseille/pleey#553. ADR 0012 records the boundary and rollout. Pleey previews this change at an immutable commit and must adopt a reviewed release before merging.

@github-actions

Copy link
Copy Markdown
Contributor

Internal - Pull request - Continuous Integration - Test results

Workflow run and full reports · Commit e1d6a24

Jobs: 10 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned.

Test: 247 passed · 0 failed · 0 skipped.

Test details

Test results

Test Results

Status Count
✅ Passed 247
❌ Failed 0
⏭️ Skipped 0
Total 247

✅ Pass Rate: 100.0%

Job results and report availability
Job Result Report artifacts
lint success 1
test-action-helm-generate-docs success 1
test-action-helm-prepare-chart success 1
test-action-helm-prepare-release success 1
test-action-helm-lint-chart success 1
test-action-helm-test-chart success 1
test-action-helm-release-chart success 1
test-action-docker-promote-images success 1
test-action-docker-verify-images success 1
test-action-docker-prune-pull-requests-image-tags success 1

Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs.

@github-actions

Copy link
Copy Markdown
Contributor

Internal - Pull request - Continuous Integration - Code coverage

Workflow run and full reports · Commit e1d6a24

Jobs: 10 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned.

Coverage: 9 source report(s); percentages remain separate.

Coverage details

Coverage results

ci-reports-1-test-action-docker-promote-images-actions-docker-promote-images-714582ba-298c-4d18-a2b8-0572817cdcf1/lcov.info

Coverage

Metric Covered Total Percentage
Lines 488 494 98.79%
Branches 82 83 98.80%
Functions 23 24 95.83%

Overall: 98.79% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

ci-reports-1-test-action-docker-prune-pull-requests-image-tags-actions-docker-prune-pull-requests-image-tags-155c493b-b9ad-4d90-8444-fd61c68113c7/lcov.info

Coverage

Metric Covered Total Percentage
Lines 192 230 83.48%
Branches 31 39 79.49%
Functions 13 14 92.86%

Overall: 83.48% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜⬜⬜

ci-reports-1-test-action-docker-verify-images-actions-docker-verify-images-9e240346-fdb3-4d94-8114-4d21d92e0e91/lcov.info

Coverage

Metric Covered Total Percentage
Lines 78 78 100.00%
Branches 16 16 100.00%
Functions 3 3 100.00%

Overall: 100.00% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

ci-reports-1-test-action-helm-generate-docs-actions-helm-generate-docs-64beccea-d387-46f4-9544-6e2bcc84aa57/lcov.info

Coverage

Metric Covered Total Percentage
Lines 368 386 95.34%
Branches 130 140 92.86%
Functions 29 30 96.67%

Overall: 95.34% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜

ci-reports-1-test-action-helm-lint-chart-actions-helm-lint-chart-0e8edb09-9f16-4bb1-a173-3e7178e24c74/lcov.info

Coverage

Metric Covered Total Percentage
Lines 193 200 96.50%
Branches 45 51 88.24%
Functions 11 13 84.62%

Overall: 96.50% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜

ci-reports-1-test-action-helm-prepare-chart-actions-helm-prepare-chart-2cb23d5d-2e4a-4958-a5f3-adae854f49ae/lcov.info

Coverage

Metric Covered Total Percentage
Lines 204 232 87.93%
Branches 60 75 80.00%
Functions 20 24 83.33%

Overall: 87.93% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜⬜

ci-reports-1-test-action-helm-prepare-release-actions-helm-prepare-release-e826df14-0153-4116-af26-8fa8f2ca2ef9/lcov.info

Coverage

Metric Covered Total Percentage
Lines 173 183 94.54%
Branches 48 55 87.27%
Functions 6 6 100.00%

Overall: 94.54% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩⬜

ci-reports-1-test-action-helm-release-chart-actions-helm-release-chart-bf2d6d7e-9464-42d9-bfd2-72e8ee0a5ab5/lcov.info

Coverage

Metric Covered Total Percentage
Lines 200 200 100.00%
Branches 51 55 92.73%
Functions 5 6 83.33%

Overall: 100.00% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

ci-reports-1-test-action-helm-test-chart-actions-helm-test-chart-3113efe0-e1f2-4685-98ad-055ee0fe2a21/lcov.info

Coverage

Metric Covered Total Percentage
Lines 257 260 98.85%
Branches 58 62 93.55%
Functions 13 13 100.00%

Overall: 98.85% 🟢
🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

Job results and report availability
Job Result Report artifacts
lint success 1
test-action-helm-generate-docs success 1
test-action-helm-prepare-chart success 1
test-action-helm-prepare-release success 1
test-action-helm-lint-chart success 1
test-action-helm-test-chart success 1
test-action-helm-release-chart success 1
test-action-docker-promote-images success 1
test-action-docker-verify-images success 1
test-action-docker-prune-pull-requests-image-tags success 1

Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs.

@github-actions

Copy link
Copy Markdown
Contributor

Internal - Pull request - Continuous Integration - Lint results

Workflow run and full reports · Commit e1d6a24

Jobs: 10 success · 0 failure · 0 cancelled · 0 skipped · 0 abandoned.

Lint: Collected diagnostics and Super-Linter summaries. Execution status is included in the job outcomes.

Super-Linter details

Super-linter summary

Language Validation result
BIOME_FORMAT Pass ✅
BIOME_LINT Pass ✅
CHECKOV Pass ✅
GITHUB_ACTIONS Pass ✅
GITHUB_ACTIONS_ZIZMOR Pass ✅
GITLEAKS Pass ✅
GIT_COMMITLINT Pass ✅
GIT_MERGE_CONFLICT_MARKERS Pass ✅
JSCPD Pass ✅
MARKDOWN Pass ✅
MARKDOWN_PRETTIER Pass ✅
NATURAL_LANGUAGE Pass ✅
PRE_COMMIT Pass ✅
SPELL_CODESPELL Pass ✅
TRIVY Pass ✅
YAML Pass ✅
YAML_PRETTIER Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter
Super-linter revision: 2da136927bd4a73596db63044b504547c62cb854
Super-linter version: 9.0.0

Job results and report availability
Job Result Report artifacts
lint success 1
test-action-helm-generate-docs success 1
test-action-helm-prepare-chart success 1
test-action-helm-prepare-release success 1
test-action-helm-lint-chart success 1
test-action-helm-test-chart success 1
test-action-helm-release-chart success 1
test-action-docker-promote-images success 1
test-action-docker-verify-images success 1
test-action-docker-prune-pull-requests-image-tags success 1

Only this attempt is included. On partial reruns, rerun all producer jobs for complete reports. CodeQL findings remain in code scanning; other diagnostics remain in the job logs.

@neilime
neilime merged commit 01c4f02 into main Nov 17, 2026
334 checks passed
@neilime
neilime deleted the feat/helm-release-artifact-input branch November 17, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: feature Introduces a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant